Code Trips & Tips

This was truly impressive: not only it had created the whole TF code and correctly created a PR (and correctly analyzed the comments from CodeRabbint’s automated code review) but it also had managed the branches, pull, etc.

Until I decided to double-check…

A simple git log command showed a puzzling absence of that commit in the log, and further investigation showed that the PR had been (literally) closed (not merged) – which, to be fair, is exactly what the LLM had told me (see point 5. there) but something that hadn’t registered, as it didn’t make any sense at all; so I had assumed what it actually meant was “merged.”

Turns out it was all my fault, this was the original prompt:

Usual routine: commit your changes in a new branch 
(feature/terraform) with a sensible commit message, 
push to a branch upstream (you can use the `g upstream` 
shortcut) and then create the PR using gh CLI.

Once the GH Action for the automated code review completes,
please review carefully the bot's comments, and address them. 

I don't need to review your changes, but make sure that 
you complete any requested changes, and address
any subsequent issues, if any. 

Then >>>close<<< the PR, pull the main branch, 
and delete the local branch

You see, when typing I’d used “close” instead of “squash and merge” without thinking too hard about it, as “closing” the PR (after pushing the commit, reviewing the comments, and doing all the legwork) would have been utterly idiotic.

Of course, the LLM happily did what it was told, common sense be damned!

Lesson for the class: always double check the bots, they’re not as clever as they’d have us believe they are 😉